Myasuka commented on a change in pull request #15046:
URL: https://github.com/apache/flink/pull/15046#discussion_r584514391
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java
##########
@@ -349,7 +349,12 @@ public int numKeyValueStatesByName() {
}
// TODO remove this once heap-based timers are working with RocksDB
incremental snapshots!
- public boolean requiresLegacySynchronousTimerSnapshots(CheckpointType
checkpointOptions) {
+ public boolean requiresLegacySynchronousTimerSnapshots(CheckpointType
checkpointType) {
+ return false;
+ }
+
+ // TODO remove this once heap-based timers are working with RocksDB
incremental snapshots!
Review comment:
I mean the `isStateImmutableInStateBackend` method. I think this comment
description dose not match the role which `isStateImmutableInStateBackend` is
playing. In other words, we cannot remove `isStateImmutableInStateBackend` even
heap-based timers could work with RocksDB incremental snapshots.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
