[
https://issues.apache.org/jira/browse/FLINK-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226250#comment-15226250
]
ASF GitHub Bot commented on FLINK-3700:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1854
[FLINK-3700] [core] Remove Guava as a dependency from "flink-core"
**Note: This builds on top of pull request #1853**
Almost all Guava functionality used within `flink-core` has corresponding
utils in Flink's codebase, or the JDK library.
This replaces the Guava code as follows
- Preconditions calls by Flink's Preconditions class
- Collection utils by simple Java Collection calls
- Iterator's by Flink's Union Iterator
- Murmur Hasher calls by Flink's `MathUtil.murmurHash()`
- Files by simple util methods around `java.nio.Files`
- InetAddresses IPv6 encoding code has been adapted into Flink's NetUtils
(with attribution comments)
Some util classes where moved from `flink-runtime` to `flink-core`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink guava_free_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1854
----
commit 535e83a297d39315d9d4b36672444b44f409c81e
Author: Stephan Ewen <[email protected]>
Date: 2016-04-05T10:37:33Z
[FLINK-3700] [build] Add 'findbugs' (javax.annotation) annotations as a
core dependency.
commit eac0813d9f7298211bf52aec61ce346a133436f8
Author: Stephan Ewen <[email protected]>
Date: 2016-04-05T11:23:14Z
[FLINK-3700] [core] Add 'Preconditions' utility class.
commit 052db9286ad8aa8df3e122c300361dbc384a0190
Author: Stephan Ewen <[email protected]>
Date: 2016-04-05T13:18:32Z
[FLINK-3700] [core] Removes Guava Dependency from flink-core
Almost all Guava functionality used within flink-core has corresponding
utils in Flink's codebase, or the JDK library.
This replaces the Guava code as follows
- Preconditions calls by Flink's Preconditions class
- Collection utils by simple Java Collection calls
- Iterator's by Flink's Union Iterator
- Files by simple util methods arount java.nio.Files
- InetAddresses IPv6 encoding code has been adapted into Flink's NetUtils
(with attribution comments)
Some util classes where moved from flink-runtime to flink-core.
----
> Replace Guava Preconditions class with Flink Preconditions
> ----------------------------------------------------------
>
> Key: FLINK-3700
> URL: https://issues.apache.org/jira/browse/FLINK-3700
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
>
> In order to reduce the dependency on Guava (which has cause us quite a bit of
> pain in the past with its version conflicts), I suggest to add a Flink
> {{Preconditions}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
