rmetzger commented on a change in pull request #14948:
URL: https://github.com/apache/flink/pull/14948#discussion_r586268421
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java
##########
@@ -501,12 +502,11 @@ public void declineCheckpoint(DeclineCheckpoint decline) {
}
@Override
- public CompletableFuture<String> stopWithSavepoint(String targetDirectory,
boolean terminate) {
+ public CompletableFuture<String> stopWithSavepoint(
+ @Nullable String targetDirectory, boolean terminate) {
return state.tryCall(
- StateWithExecutionGraph.class,
- stateWithExecutionGraph ->
- stateWithExecutionGraph.stopWithSavepoint(
- targetDirectory, terminate),
+ Executing.class,
+ executing ->
executing.stopWithSavepoint(targetDirectory, terminate),
"stopWithSavepoint")
.orElse(
FutureUtils.completedExceptionally(
Review comment:
But the user requested the creation of a checkpoint, which failed
because we were in the wrong state.
I believe we are using the correct exception here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
