[
https://issues.apache.org/jira/browse/FLINK-21587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294935#comment-17294935
]
Yangze Guo commented on FLINK-21587:
------------------------------------
Thanks for the report [~rmetzger]. I think this issue might come from the
following snippet:
{code:java}
resourceActionsBuilder.setNotEnoughResourcesConsumer(
(jobId1, acquiredResources) -> {
notifyNotEnoughResourceFuture.complete(null);
notEnoughResourceNotifications.add(
Tuple2.of(jobId1, acquiredResources));
});
{code}
The {{notifyNotEnoughResourceFuture}} should be completed after the
notification added to the list.
I've looped the test 10,000 times to verify it.
> FineGrainedSlotManagerTest.testNotificationAboutNotEnoughResources is unstable
> ------------------------------------------------------------------------------
>
> Key: FLINK-21587
> URL: https://issues.apache.org/jira/browse/FLINK-21587
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.13.0
> Reporter: Robert Metzger
> Priority: Critical
> Labels: test-stability
> Fix For: 1.13.0
>
>
> Happened in my WIP branch, but most likely unrelated to my change:
> https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8925&view=logs&j=9dc1b5dc-bcfa-5f83-eaa7-0cb181ddc267&t=ab910030-93db-52a7-74a3-34a0addb481b
> Also note that the error is reproducable locally with DEBUG log level, but
> not with INFO:
> {code}
> [ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 2.169 s <<< FAILURE! - in
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest
> [ERROR]
> testNotificationAboutNotEnoughResources(org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest)
> Time elapsed: 0.029 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a collection with size <1>
> but: collection size was <0>
> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> at org.junit.Assert.assertThat(Assert.java:956)
> at org.junit.Assert.assertThat(Assert.java:923)
> at
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest$9.lambda$new$5(FineGrainedSlotManagerTest.java:548)
> at
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTestBase$Context.runTest(FineGrainedSlotManagerTestBase.java:197)
> at
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest$9.<init>(FineGrainedSlotManagerTest.java:521)
> at
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testNotificationAboutNotEnoughResources(FineGrainedSlotManagerTest.java:507)
> at
> org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testNotificationAboutNotEnoughResources(FineGrainedSlotManagerTest.java:493)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
