leonardBang commented on a change in pull request #14684: URL: https://github.com/apache/flink/pull/14684#discussion_r587208036
########## File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseSerde.java ########## @@ -225,6 +217,13 @@ public Get createGet(Object rowKey) { /** Converts HBase {@link Result} into {@link RowData}. */ public RowData convertToRow(Result result) { + // The output rows needs to be initialized each time Review comment: Could we add a `reuse` flag for this function so that we can improve the performance when user didn't enable the cache or used in the HBaseRowDataInputFormat ########## File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/source/HBaseRowDataAsyncLookupFunctionTest.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.hbase2.source; + +import org.apache.flink.connector.hbase.options.HBaseLookupOptions; +import org.apache.flink.connector.hbase.util.HBaseTableSchema; +import org.apache.flink.connector.hbase.util.PlannerType; +import org.apache.flink.connector.hbase2.util.HBaseTestBase; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.data.RowData; + +import org.apache.flink.shaded.guava18.com.google.common.collect.Lists; + +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.concurrent.CompletableFuture; +import java.util.stream.Collectors; + +import static org.junit.Assert.assertEquals; + +/** Test suite for {@link HBaseRowDataAsyncLookupFunction}. */ +public class HBaseRowDataAsyncLookupFunctionTest extends HBaseTestBase { Review comment: Could we add an ITCase for `AsyncLookupFunction` like `HBaseConnectorITCase.testHBaseLookupTableSource` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org