XComp commented on a change in pull request #15049:
URL: https://github.com/apache/flink/pull/15049#discussion_r587599429
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java
##########
@@ -87,18 +87,23 @@ protected JobExceptionsInfo handleRequest(
}
@Override
- public Collection<ArchivedJson> archiveJsonWithPath(AccessExecutionGraph
graph)
+ public Collection<ArchivedJson> archiveJsonWithPath(ExecutionGraphInfo
executionGraphInfo)
throws IOException {
- ResponseBody json = createJobExceptionsInfo(graph,
MAX_NUMBER_EXCEPTION_TO_REPORT);
+ ResponseBody json =
+ createJobExceptionsInfo(executionGraphInfo,
MAX_NUMBER_EXCEPTION_TO_REPORT);
String path =
getMessageHeaders()
.getTargetRestEndpointURL()
- .replace(':' + JobIDPathParameter.KEY,
graph.getJobID().toString());
+ .replace(
+ ':' + JobIDPathParameter.KEY,
+ executionGraphInfo.getJobId().toString());
return Collections.singletonList(new ArchivedJson(path, json));
}
private static JobExceptionsInfo createJobExceptionsInfo(
- AccessExecutionGraph executionGraph, int exceptionToReportMaxSize)
{
+ ExecutionGraphInfo executionGraphInfo, int
exceptionToReportMaxSize) {
+ final ArchivedExecutionGraph executionGraph =
+ executionGraphInfo.getArchivedExecutionGraph();
Review comment:
Fair point. I missed that when adding the `ExecutionGraphInfo` because
it was replacing the `ArchivedExecutionGraph`. I changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
