pnowojski commented on a change in pull request #15075: URL: https://github.com/apache/flink/pull/15075#discussion_r588068601
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/JobConfiguration.java ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package org.apache.flink.runtime.scheduler.benchmark; + +import org.apache.flink.api.common.ExecutionMode; +import org.apache.flink.runtime.io.network.partition.ResultPartitionType; +import org.apache.flink.runtime.jobgraph.DistributionPattern; +import org.apache.flink.runtime.jobgraph.ScheduleMode; + +/** + * {@link JobConfiguration} contains the configuration of a STREAMING/BATCH job. It concludes {@link + * DistributionPattern}, {@link ResultPartitionType}, {@link ScheduleMode}, {@link ExecutionMode}. + */ +public enum JobConfiguration { + STREAMING( + DistributionPattern.ALL_TO_ALL, + ResultPartitionType.PIPELINED, + ScheduleMode.EAGER, Review comment: AFAIK this won't compile on the recent master ########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/topology/BuildExecutionGraphBenchmarkExecutor.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package org.apache.flink.runtime.scheduler.benchmark.topology; + +import org.apache.flink.runtime.executiongraph.ExecutionGraph; +import org.apache.flink.runtime.executiongraph.TestingExecutionGraphBuilder; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.scheduler.benchmark.JobConfiguration; + +import java.util.List; + +import static org.apache.flink.runtime.scheduler.benchmark.SchedulerBenchmarkUtils.createDefaultJobVertices; +import static org.apache.flink.runtime.scheduler.benchmark.SchedulerBenchmarkUtils.createJobGraph; + +/** + * The benchmark of building the topology of {@link ExecutionGraph} in a STREAMING/BATCH job. The + * related method is {@link ExecutionGraph#attachJobGraph}, + */ +public class BuildExecutionGraphBenchmarkExecutor { Review comment: I would suggest to unify naming convention with the network benchmarks. So far it was like this: - `*BenchmarkExecutor` resides in the `flink-benchmarks` repository - `*Benchmark` class resides in the `flink` repository so it's the other way compared to this. Reasoning is that the benchmark resides in the `flink` repo, while code executing the benchmark via JMH is in the `flink-benchmarks` repo. I'm not strongly attached to the current naming scheme, we could modify it, but at least I would keep it the same in all benchmarks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
