wuchong commented on a change in pull request #15026: URL: https://github.com/apache/flink/pull/15026#discussion_r588069791
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowRank.scala ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.table.planner.plan.nodes.physical.stream + +import org.apache.flink.table.planner.plan.logical.WindowingStrategy +import org.apache.flink.table.planner.plan.nodes.calcite.Rank +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode +import org.apache.flink.table.planner.plan.utils._ +import org.apache.flink.table.runtime.operators.rank._ + +import org.apache.calcite.plan.{RelOptCluster, RelTraitSet} +import org.apache.calcite.rel._ +import org.apache.calcite.rel.`type`.RelDataTypeField +import org.apache.calcite.util.ImmutableBitSet + +import java.util + +import scala.collection.JavaConversions._ +import scala.collection.JavaConverters._ + +/** + * Stream physical RelNode for [[Rank]] requires PARTITION BY clause contains start and end + * columns of the windowing TVF. + */ +class StreamPhysicalWindowRank( + cluster: RelOptCluster, + traitSet: RelTraitSet, + inputRel: RelNode, + partitionKey: ImmutableBitSet, + orderKey: RelCollation, + rankType: RankType, + rankRange: RankRange, + rankNumberType: RelDataTypeField, + outputRankNumber: Boolean, + val windowing: WindowingStrategy) + extends Rank( + cluster, + traitSet, + inputRel, + partitionKey, + orderKey, + rankType, + rankRange, + rankNumberType, + outputRankNumber) + with StreamPhysicalRel { + + override def requireWatermark: Boolean = windowing.isRowtime + + override def copy(traitSet: RelTraitSet, inputs: util.List[RelNode]): RelNode = { + new StreamPhysicalWindowRank( + cluster, + traitSet, + inputs.get(0), + partitionKey, + orderKey, + rankType, + rankRange, + rankNumberType, + outputRankNumber, + windowing) + } + + override def explainTerms(pw: RelWriter): RelWriter = { + val inputRowType = inputRel.getRowType + val inputFieldNames = inputRowType.getFieldNames.asScala.toArray + pw.input("input", getInput) + .item("rankType", rankType) + .item("rankRange", rankRange.toString(inputRowType.getFieldNames)) + .item("partitionBy", RelExplainUtil.fieldToString(partitionKey.toArray, inputRowType)) + .item("orderBy", RelExplainUtil.collationToString(orderKey, inputRowType)) + .item("window", windowing.toSummaryString(inputFieldNames)) Review comment: I think window is the most important information of window topn. Could we move "window" before "rankType"? This can make the operator name in Web UI more readable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
