[
https://issues.apache.org/jira/browse/FLINK-21635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296011#comment-17296011
]
Kezhu Wang commented on FLINK-21635:
------------------------------------
I think we could go through `Nullable` first to make {{driverName}} optional.
For the user-facing part of {{JdbcConnectionOptions}}, nullability of
{{getDriverName}} is pure decided by {{driverName}} fed by users so it is
actually no a breaking change in caller side. We can always fallback to
renaming approach if users complain about inconsistent finally.
[~jark] What do you think ?
> Driver name is optional for DriverManager.getConnection but a must in
> JdbcConnectionOptions
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-21635
> URL: https://issues.apache.org/jira/browse/FLINK-21635
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / JDBC
> Affects Versions: 1.13.0
> Reporter: Kezhu Wang
> Priority: Major
>
> The most annoying/sad part is that we should change {{getDriverName}} to
> {{Optional}} according to [code
> style|https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional](which
> is a breaking change in user side since {{JdbcConnectionOptions}} is
> {{PublicEvolving}}) if we make {{driverName}} optional.
> cc [~jark] [~roman_khachatryan] [~lzljs3620320]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
