tillrohrmann commented on a change in pull request #14948:
URL: https://github.com/apache/flink/pull/14948#discussion_r588461703
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/stopwithsavepoint/StopWithSavepointOperationManager.java
##########
@@ -45,18 +57,28 @@ public StopWithSavepointTerminationManager(
* Enforces the correct completion order of the passed {@code
CompletableFuture} instances in
* accordance to the contract of {@link
StopWithSavepointTerminationHandler}.
*
- * @param completedSavepointFuture The {@code CompletableFuture} of the
savepoint creation step.
+ * @param terminate Flag indicating whether to terminate or suspend the
job.
+ * @param targetDirectory Target for the savepoint.
* @param terminatedExecutionStatesFuture The {@code CompletableFuture} of
the termination step.
* @param mainThreadExecutor The executor the {@code
StopWithSavepointTerminationHandler}
* operations run on.
* @return A {@code CompletableFuture} containing the path to the created
savepoint.
*/
- public CompletableFuture<String> stopWithSavepoint(
- CompletableFuture<CompletedCheckpoint> completedSavepointFuture,
+ public CompletableFuture<String> trackStopWithSavepoint(
+ boolean terminate,
Review comment:
Sounds good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
