[ 
https://issues.apache.org/jira/browse/FLINK-21660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297306#comment-17297306
 ] 

Rui Li edited comment on FLINK-21660 at 3/8/21, 12:13 PM:
----------------------------------------------------------

I'd prefer to deprecate the {{"is_generic"}} flag, and follow flink's 
convention to use {{"connector"}} to distinguish hive and non-hive tables. I 
guess it'll make the logic simpler and avoid more issues in the future.

If we do that, we need to keep backward compatibility in mind -- tables created 
by an older HiveCatalog should continue to be usable after this change.


was (Author: lirui):
I'd prefer to deprecate the {{"is_generic"}} flag, and follow flink's 
convention to use {{"connector"}} to distinguish hive and non-hive tables. I 
guess it'll make the logic simpler and void more issues in the future.

If we do that, we need to keep backward compatibility in mind -- tables created 
by an older HiveCatalog should continue to be usable after this change.

> create table can not like with hive catalog table
> -------------------------------------------------
>
>                 Key: FLINK-21660
>                 URL: https://issues.apache.org/jira/browse/FLINK-21660
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>    Affects Versions: 1.12.1
>            Reporter: liqiang.liu
>            Priority: Major
>
> create a table like with a hive catalog table
> {color:#cc7832}CREATE TABLE {color}temp_order
> {color:#cc7832}WITH {color}(
>  {color:#6a8759}'properties.group.id' {color}= 
> {color:#6a8759}'test1'{color}{color:#cc7832},
> {color} {color:#6a8759}'properties.bootstrap.servers' {color}= 
> {color:#6a8759}'kafka.address'
> {color})
> {color:#cc7832}LIKE {color}hive.ods.flink_order
> It has a error, log is :
>  
> Exception in thread "main" org.apache.flink.table.api.ValidationException: 
> Unable to create a source for reading table 
> 'default_catalog.default_database.test_taos_customer_agent_cinema'.
> Table options are:
> 'connector'='upsert-kafka'
> 'is_generic'='true'
> 'key.format'='json'
> 'properties.bootstrap.servers'='kafka.address'
> 'properties.group.id'='test1'
> 'topic'='topic1'
> 'value.format'='json'
> ...
> Caused by: org.apache.flink.table.api.ValidationException: Unsupported 
> options found for connector 'upsert-kafka'.
> Unsupported options:
> is_generic
>  
> the ’is_generic‘ option is  added by hive catalog,  but  `kafka` connector  
> does not support this  option.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to