Thesharing commented on a change in pull request #15088:
URL: https://github.com/apache/flink/pull/15088#discussion_r589909597
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultExecutionTopology.java
##########
@@ -130,7 +131,8 @@ public EdgeManager getEdgeManager() {
return edgeManager;
}
- public static DefaultExecutionTopology fromExecutionGraph(ExecutionGraph
executionGraph) {
+ public static DefaultExecutionTopology fromExecutionGraph(
+ DefaultExecutionGraph executionGraph) {
Review comment:
> Why do we need this change? Or should this commit be ahead of the
commit to "Optimize the initialization of DefaultExecutionTopology"?
Because `EdgeManager` is located at `InternalExecutionGraphAccessor`
interface rather than `ExecutionGraph` interface. To get `EdgeManager`, I'd
prefer to pass the `DefaultExecutionGraph` as the parameter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
