LinyuYao1021 removed a comment on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-793563537
> > It looks like the GSR test is running even when the creds are not set. Can we try setting: > > ``` > > if [ -n "$IT_CASE_GLUE_SCHEMA_ACCESS_KEY" ] && [ -n "$IT_CASE_GLUE_SCHEMA_SECRET_KEY" ]; then > > run_test "AWS Glue Schema Registry nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_glue_schema_registry.sh" > > fi > > ``` > > > > > > to > > ``` > > if [ "$IT_CASE_GLUE_SCHEMA_ACCESS_KEY" ] && [ "$IT_CASE_GLUE_SCHEMA_SECRET_KEY" ]; then > > run_test "AWS Glue Schema Registry nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_glue_schema_registry.sh" > > fi > > ``` > > Updated After diving into this, I find that `-n` means whether a string is empty, which is same with the length is zero. So we can use it for the condition check. The problem is we should use `[[ ]]` instead of `[ ]` to ensure > The `-z` approach should work: https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/common_s3.sh#L25 > but it's worth a try. > > Can you also add > > ``` > SECRET_S3_ACCESS_KEY: $[variables.IT_CASE_S3_ACCESS_KEY] > SECRET_S3_SECRET_KEY: $[variables.IT_CASE_S3_SECRET_KEY] > ``` > > to `build-apache-repo.yml`? Yes, I've added in the latest commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
