[
https://issues.apache.org/jira/browse/FLINK-16829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298507#comment-17298507
]
Rion Williams commented on FLINK-16829:
---------------------------------------
I'd be interested in working on this. Since the amount of arguments for the
PrometheusReporter would likely be pretty minimal (just a port I believe), it'd
really just be a matter of adjusting the factory to pass those into new
reporter instance correct?
{code:java}
public PrometheusReporter createMetricReporter(Properties properties) {
return new PrometheusReporter();
}
{code}
It seems pretty straight-forward unless there's something glaring that I'm
missing.
> Pass PrometheusReporter arguments via constructor
> -------------------------------------------------
>
> Key: FLINK-16829
> URL: https://issues.apache.org/jira/browse/FLINK-16829
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: starter
> Fix For: 1.13.0
>
>
> With FLINK-16828 Prometheus reporters are now instantiated via factories. We
> can now refactor the initialization to pass all parameter through the
> constructor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
