[ 
https://issues.apache.org/jira/browse/FLINK-20979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298509#comment-17298509
 ] 

Jark Wu commented on FLINK-20979:
---------------------------------

Hi [~dwysakowicz], I think the documentation is correct. We will convert value 
"0" to "-1" when getting this option value. Using "0" to disable it is in order 
to keep consistent with other options (e.g. sink.bulk-flush.max-size), because 
MemorySize and Duration doesn't allow negative values. 

> Wrong description of 'sink.bulk-flush.max-actions'
> --------------------------------------------------
>
>                 Key: FLINK-20979
>                 URL: https://issues.apache.org/jira/browse/FLINK-20979
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / ElasticSearch, Documentation, Table SQL / 
> Ecosystem
>    Affects Versions: 1.12.0
>            Reporter: Dawid Wysakowicz
>            Priority: Major
>              Labels: pull-request-available, starter
>             Fix For: 1.13.0, 1.12.3
>
>
> The documentation claims the option can be disabled with '0', but it can 
> actually be disable with '-1' whereas '0' is an illegal value.
> {{Maximum number of buffered actions per bulk request. Can be set to '0' to 
> disable it. }}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to