tillrohrmann commented on a change in pull request #15105:
URL: https://github.com/apache/flink/pull/15105#discussion_r591583613



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/DefaultJobLeaderService.java
##########
@@ -470,6 +475,7 @@ protected void onRegistrationFailure(Throwable failure) {
             return gateway.registerTaskManager(
                     taskManagerRpcAddress,
                     unresolvedTaskManagerLocation,
+                    jobId,

Review comment:
       The `fencingToken` is a concept of the underlying `RpcSystem` whereas 
the `JobID` is a concept of the "application layer". That's why it is not 
guaranteed that fencing tokens are different iff `JobIDs` are different. An 
example is a non-ha setup where the fencing token is always `0`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to