[
https://issues.apache.org/jira/browse/FLINK-11832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jark Wu closed FLINK-11832.
---------------------------
Resolution: Invalid
The methods {{needCloneRefForType}} and {{needCopyForType}} of {{CodeGenUtils}}
have been removed.
> Convert some InternalType property related functions to InternalType's method
> -----------------------------------------------------------------------------
>
> Key: FLINK-11832
> URL: https://issues.apache.org/jira/browse/FLINK-11832
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Reporter: Kurt Young
> Priority: Major
>
> For example, in `CodeGenUtils` we have some utils methods like
> `needCopyForType` and `needCloneRefForType`. They are very error prone
> because there is no guarantee when someone add a new InternalType, he will
> check this functionality.
> There also exists some pattern-match style codes based on types, i think a
> feasible principle when to convert these to class's method and when to keep
> they as pattern-match is:
> "If the pattern-match codes stand for all further changes, we can keep it as
> it is. Otherwise, we should convert it to class's method as much as
> possible".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
