[
https://issues.apache.org/jira/browse/FLINK-17532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299092#comment-17299092
]
Jan Brusch commented on FLINK-17532:
------------------------------------
[~twalthr] Is this still open and relevant? If so, I would like to work on it.
Best regards
> Update tests to use BatchTestBase#checkTableResult
> --------------------------------------------------
>
> Key: FLINK-17532
> URL: https://issues.apache.org/jira/browse/FLINK-17532
> Project: Flink
> Issue Type: Test
> Components: Table SQL / Planner
> Reporter: Timo Walther
> Priority: Major
> Labels: starter
>
> Roughly 196 tests fail if we change the `Row.toString`. In the legacy
> planner, we will fix this quickly using some util. However, for the long-term
> Blink planner we should update those test to use the test bases and compare
> against instances instead of string.
> Similar to:
> {code}
> checkResult(
> "SELECT j, sum(k) FROM GenericTypedTable3 GROUP BY i, j",
> Seq(
> row(row(1, 1), 2),
> row(row(1, 1), 2),
> row(row(10, 1), 3)
> )
> )
> {code}
> Affected tests:
> {code}
> AggregateITCaseBase
> PartitionableSinkITCase
> CalcITCase
> JoinITCase
> SortITCase
> CorrelateITCase
> TableSinkITCase
> AggregationITCase
> GroupWindowITCase
> SetOperatorsITCase
> CalcITCase
> UnnestITCase
> AggregateRemoveITCase
> PruneAggregateCallITCase
> CalcITCase
> CorrelateITCase
> TableSinkITCase
> SetOperatorsITCase
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
