fsk119 commented on a change in pull request #15006: URL: https://github.com/apache/flink/pull/15006#discussion_r592031634
########## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.client.gateway.context; + +import org.apache.flink.client.cli.DefaultCLI; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.client.config.Environment; +import org.apache.flink.table.client.gateway.utils.EnvironmentFileUtil; + +import org.junit.Assert; +import org.junit.Test; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; + +import static org.apache.flink.table.api.config.TableConfigOptions.TABLE_SQL_DIALECT; + +/** Test {@link SessionContext}. */ +public class SessionContextTest { + + private static final String DEFAULTS_ENVIRONMENT_FILE = "test-sql-client-defaults.yaml"; + + @Test + public void testSetAndResetYamlKey() throws Exception { + SessionContext sessionContext = createSessionContext(); + sessionContext.set("execution.max-table-result-rows", "100000"); + Assert.assertEquals( + "100000", + sessionContext + .getSessionEnvironment() + .getExecution() + .asMap() + .get("max-table-result-rows")); + + sessionContext.reset(); + + Assert.assertEquals( + "100", Review comment: After offline discussion, - reset should reset value to the value set in the yaml. - it should reset to the default value if yaml doesn't set the value. - it should clear the value if it doesn't have default value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
