rkhachatryan commented on a change in pull request #14754: URL: https://github.com/apache/flink/pull/14754#discussion_r592232907
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/FullyFinishedOperatorState.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.checkpoint; + +import org.apache.flink.runtime.jobgraph.OperatorID; + +/** + * A special operator state implementation representing the operators whose instances are all + * finished. + */ +public class FullyFinishedOperatorState extends OperatorState { Review comment: Should this class also override `equals`/`hashCode`? And why do we allow to set coordinator state (i.e. don't override like `putState`)? Can finished vertex have coordinator state? ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java ########## @@ -103,11 +105,16 @@ protected void serializeOperatorState(OperatorState operatorState, DataOutputStr serializeStreamStateHandle(operatorState.getCoordinatorState(), dos); // Sub task states - final Map<Integer, OperatorSubtaskState> subtaskStateMap = operatorState.getSubtaskStates(); - dos.writeInt(subtaskStateMap.size()); - for (Map.Entry<Integer, OperatorSubtaskState> entry : subtaskStateMap.entrySet()) { - dos.writeInt(entry.getKey()); - serializeSubtaskState(entry.getValue(), dos); + if (operatorState.isFullyFinished()) { + dos.writeInt(-1); Review comment: nit: to me, explicitly writing `isFullyFinished` would be more clear and less error-prone: ``` dos.writeBoolean(operatorState.isFullyFinished()); dos.writeInt(subtaskStateMap.size()); // zero // empty loop ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
