curcur commented on a change in pull request #14943:
URL: https://github.com/apache/flink/pull/14943#discussion_r592262036
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
##########
@@ -193,24 +193,24 @@ protected CheckpointStreamFactory createStreamFactory()
throws Exception {
return checkpointStreamFactory;
}
- protected <K> AbstractKeyedStateBackend<K>
createKeyedBackend(TypeSerializer<K> keySerializer)
- throws Exception {
+ protected <K> CheckpointableKeyedStateBackend<K> createKeyedBackend(
Review comment:
The reason is that all the tests (including 4 different extensions of
StateBackendTestBase.java) are reused by ChangelogStateBackend.
"ChangelogKeyedStateBackend" is not an "AbstractKeyedStateBackend"; it is a
`CheckpointableKeyedStateBackend` instead, that's why the change is made.
If not made this way, we would have to rewrite and duplicatete all the tests
(which are similar to what are included in StateBackendTestBase)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
