Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1862#issuecomment-207438727
  
    Thanks for the PR. I had a few minor comments but otherwise it looks really 
good. 
    
    There are a few follow up issues, IMO:
    - Check if we somehow can get around the `EnumerableToLogicalTableScan`. 
Maybe the Calcite community can help. I will open a JIRA for this once the PR 
is merged.
    - Check how we can exclude unsupported SQL features such as outer joins, 
intersection, etc. Also here, the Calcite community should be able to help. I 
will open a JIRA for this once the PR is merged.
    - Refactor `TranslationContext` and `TableEnvironment` to prevent that the 
same planner is used several times. I'll start a discussion about this soon.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to