[ 
https://issues.apache.org/jira/browse/FLINK-21419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300218#comment-17300218
 ] 

Till Rohrmann commented on FLINK-21419:
---------------------------------------

I agree with [~kezhuw] that multiple frees are a misuse of the 
{{MemorySegments}} because it indicates that there is no clear ownership and 
the {{MemorySegments}} are not thread safe. We should definitely try to hunt 
these places down and fix them. What one could do is to make whether to fail or 
not to fail in case of multiple frees configurable. In the dev build setup we 
could enable it and thereby find the problematic cases. Once we are sure that 
we have fixed all places one could enable to fail in case of multiple accesses 
always.

Concerning the cleaners I see the benefit of having a safety net against native 
memory leaks. Having at least something like a leak detector which fails if it 
detects leaks could be indeed helpful.

> Remove GC cleaner mechanism for unsafe memory segments
> ------------------------------------------------------
>
>                 Key: FLINK-21419
>                 URL: https://issues.apache.org/jira/browse/FLINK-21419
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>            Reporter: Xintong Song
>            Assignee: Nicholas Jiang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.13.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to