[jira] [Commented] (FLINK-21738) reduce unnecessary method calls in ModuleManager

[zoucao (Jira)]

    [ 
https://issues.apache.org/jira/browse/FLINK-21738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300239#comment-17300239
 ] 

zoucao commented on FLINK-21738:
--------------------------------

Hi [~qingyue], thanks for your advice(y), I found this DML as an example from 
my business partner randomly, and it has a little problem.

I think we can fix this topic first and then discuss other optimization topic 
about loading udf, WDYS ？

> reduce unnecessary method calls  in ModuleManager
> -------------------------------------------------
>
>                 Key: FLINK-21738
>                 URL: https://issues.apache.org/jira/browse/FLINK-21738
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: zoucao
>            Priority: Major
>
> In flink sql, if we use many functions(hive func or flink built-in func), 
> Flink will call method
> `getFunctionDefinition` in 
> [ModuleManager|https://github.com/apache/flink/blob/97bfd049951f8d52a2e0aed14265074c4255ead0/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleManager.java#L44]
>  many times to load func and each module's method `listFunctions` will be 
> called at the same time. I think the same result will be returned for one 
> module, so maybe a cache should be used here to reduce time waste.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)