rionmonster commented on a change in pull request #15175:
URL: https://github.com/apache/flink/pull/15175#discussion_r593831333
##########
File path:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java
##########
@@ -51,75 +42,21 @@
"org.apache.flink.metrics.prometheus.PrometheusPushGatewayReporterFactory")
public class PrometheusPushGatewayReporter extends AbstractPrometheusReporter
implements Scheduled {
- private PushGateway pushGateway;
- private String jobName;
- private boolean deleteOnShutdown;
- private Map<String, String> groupingKey;
-
- @Override
- public void open(MetricConfig config) {
- super.open(config);
-
- String host = config.getString(HOST.key(), HOST.defaultValue());
- int port = config.getInteger(PORT.key(), PORT.defaultValue());
- String configuredJobName = config.getString(JOB_NAME.key(),
JOB_NAME.defaultValue());
- boolean randomSuffix =
- config.getBoolean(
- RANDOM_JOB_NAME_SUFFIX.key(),
RANDOM_JOB_NAME_SUFFIX.defaultValue());
- deleteOnShutdown =
- config.getBoolean(DELETE_ON_SHUTDOWN.key(),
DELETE_ON_SHUTDOWN.defaultValue());
- groupingKey =
- parseGroupingKey(config.getString(GROUPING_KEY.key(),
GROUPING_KEY.defaultValue()));
-
- if (host == null || host.isEmpty() || port < 1) {
- throw new IllegalArgumentException(
- "Invalid host/port configuration. Host: " + host + " Port:
" + port);
- }
-
- if (randomSuffix) {
- this.jobName = configuredJobName + new AbstractID();
- } else {
- this.jobName = configuredJobName;
- }
-
- pushGateway = new PushGateway(host + ':' + port);
- log.info(
- "Configured PrometheusPushGatewayReporter with {host:{},
port:{}, jobName:{}, randomJobNameSuffix:{}, deleteOnShutdown:{},
groupingKey:{}}",
- host,
- port,
- jobName,
- randomSuffix,
- deleteOnShutdown,
- groupingKey);
- }
-
- Map<String, String> parseGroupingKey(final String groupingKeyConfig) {
- if (!groupingKeyConfig.isEmpty()) {
- Map<String, String> groupingKey = new HashMap<>();
- String[] kvs = groupingKeyConfig.split(";");
- for (String kv : kvs) {
- int idx = kv.indexOf("=");
- if (idx < 0) {
- log.warn("Invalid prometheusPushGateway groupingKey:{},
will be ignored", kv);
- continue;
- }
-
- String labelKey = kv.substring(0, idx);
- String labelValue = kv.substring(idx + 1);
- if (StringUtils.isNullOrWhitespaceOnly(labelKey)
- || StringUtils.isNullOrWhitespaceOnly(labelValue)) {
- log.warn(
- "Invalid groupingKey {labelKey:{}, labelValue:{}}
must not be empty",
- labelKey,
- labelValue);
- continue;
- }
- groupingKey.put(labelKey, labelValue);
- }
-
- return groupingKey;
- }
- return Collections.emptyMap();
+ private final PushGateway pushGateway;
+ private final String jobName;
+ private final Map<String, String> groupingKey;
+ private final boolean deleteOnShutdown;
+
+ PrometheusPushGatewayReporter(
+ @Nullable PushGateway pushGateway,
+ @Nullable String jobName,
Review comment:
Updated accordingly (although `pushGateway` is no longer an argument).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
