[ https://issues.apache.org/jira/browse/FLINK-3492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234952#comment-15234952 ]
ASF GitHub Bot commented on FLINK-3492: --------------------------------------- Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/1794#discussion_r59193164 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java --- @@ -1066,26 +1069,23 @@ public Void answer(InvocationOnMock invocation) throws Throwable { coord.startCheckpointScheduler(); - //trigger first checkpoint - Thread.sleep(100); - - assertEquals(1, numCalls.get()); - - //no new checkpoint has been triggered - Thread.sleep(100); - assertEquals(1, numCalls.get()); - - //no new checkpoint has been triggered - Thread.sleep(100); - assertEquals(1, numCalls.get()); - - //new checkpoint has been triggered - Thread.sleep(300); - assertEquals(2, numCalls.get()); + for (int x=0; x<20; x++) { + Thread.sleep(100); + if (numCalls.get() > 0) { --- End diff -- And somehow you removed the comments. I would like to add them back (at the end of the test as well) to make it easier to understand what's happening. ;) > Allow users to define a min pause between checkpoints > ----------------------------------------------------- > > Key: FLINK-3492 > URL: https://issues.apache.org/jira/browse/FLINK-3492 > Project: Flink > Issue Type: Improvement > Components: Streaming > Reporter: Robert Metzger > Assignee: Chesnay Schepler > > FLINK-3051 introduced already a filed in the {{CheckpointConfig}} to specify > a min pause between checkpoints. > In high-load situations (big state), jobs might spend their entire time > creating snapshots, not processing data. With a min pause between > checkpoints, users can guarantee that there is a certain time-span the system > can use for doing some actual data processing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)