Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1866#issuecomment-208312329
Looks good. One optimization suggestion: Replace
```java
if (value > this.max) {
this.max = value;
}
```
by
```java
this.max = Math.max(this.max, value);
```
That is a branch-free variant, because (as far as I know) these Math
functions are JIT intrinsics and become special assembler instructions in the
end.
(See:
http://www.slideshare.net/RednaxelaFX/green-teajug-hotspotintrinsics02232013
and
http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/87ee5ee27509/src/share/vm/classfile/vmSymbols.hpp)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
