wangyang0918 commented on a change in pull request #15214:
URL: https://github.com/apache/flink/pull/15214#discussion_r594159810
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParametersTest.java
##########
@@ -147,6 +149,11 @@ public void testGetDynamicProperties() {
assertEquals(DYNAMIC_PROPERTIES,
kubernetesTaskManagerParameters.getDynamicProperties());
}
+ @Test
+ public void testGetJvmMemOptsEnv() {
+ assertEquals(JVM_MEM_OPTS_ENV,
kubernetesTaskManagerParameters.getJvmMemOptsEnv());
Review comment:
nit: I think the new introduced tests are using `assertThat`.
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/KubernetesTaskManagerTestBase.java
##########
@@ -35,6 +35,7 @@
protected static final String POD_NAME = "taskmanager-pod-1";
protected static final String DYNAMIC_PROPERTIES = "";
+ protected static final String JVM_MEM_OPTS_ENV = "-Xmx:1234";
Review comment:
nit: The testing jvm opts is not in a correct format. Maybe `-Xmx512m`
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesTaskManagerParametersTest.java
##########
@@ -49,6 +49,7 @@
private static final String POD_NAME = "task-manager-pod-1";
private static final String DYNAMIC_PROPERTIES = "-Dkey.b='b2'";
+ private static final String JVM_MEM_OPTS_ENV = "-Xmx:1234";
Review comment:
Same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
