dawidwys commented on pull request #15168: URL: https://github.com/apache/flink/pull/15168#issuecomment-799259758
Overall LGTM. I don't necessarily like using the `addSplitsBack` method for discovering a restart, but I can't think of a better way for now. As we discussed offline we might need to extend the `Source/SourceReader/SplitEnumerator` interfaces to expose such information in the future. Let's first see if there are such user requests first. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org