Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1838#discussion_r59233074
  
    --- Diff: 
flink-optimizer/src/test/java/org/apache/flink/optimizer/operators/CoGroupGlobalPropertiesCompatibilityTest.java
 ---
    @@ -35,7 +37,7 @@ public void checkCompatiblePartitionings() {
                        final FieldList keysLeft = new FieldList(1, 4);
                        final FieldList keysRight = new FieldList(3, 1);
                        
    -                   CoGroupDescriptor descr = new 
CoGroupDescriptor(keysLeft, keysRight);
    +                   CoGroupDescriptor descr1 = new 
CoGroupDescriptor(keysLeft, keysRight);
    --- End diff --
    
    Can't we use this object for the new test as well? Then we would not need 
to rename it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to