hehuiyuan commented on a change in pull request #15244:
URL: https://github.com/apache/flink/pull/15244#discussion_r595737815
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -212,7 +212,10 @@ private static HiveConf createHiveConf(
@Nullable String hiveConfDir, @Nullable String hadoopConfDir) {
// create HiveConf from hadoop configuration with hadoop conf
directory configured.
Configuration hadoopConf = null;
- if (isNullOrWhitespaceOnly(hadoopConfDir)) {
+ if (!isNullOrWhitespaceOnly(hadoopConfDir)) {
+ hadoopConf = getHadoopConfiguration(hadoopConfDir);
+ }
+ if (hadoopConf == null) {
Review comment:
Hi, make some changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
