twalthr commented on a change in pull request #15242:
URL: https://github.com/apache/flink/pull/15242#discussion_r595842439
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/DataStreamQueryOperation.java
##########
@@ -49,7 +50,7 @@
private final ObjectIdentifier identifier;
private final DataStream<E> dataStream;
private final int[] fieldIndices;
- private final TableSchema tableSchema;
+ private final ResolvedSchema resolvedSchema;
// TODO remove this while TableSchema supports fieldNullables
Review comment:
this comment still makes sense and is actually targeted at FLIP-136. We
currently don't set the nullability properly in the data types of
`ResolvedSchema`. I updated the comment with the new class though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
