godfreyhe commented on a change in pull request #15215:
URL: https://github.com/apache/flink/pull/15215#discussion_r596530326
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecCorrelate.java
##########
@@ -58,7 +76,29 @@ public CommonExecCorrelate(
InputProperty inputProperty,
RowType outputType,
String description) {
- super(Collections.singletonList(inputProperty), outputType,
description);
+ this(
+ joinType,
+ invocation,
+ condition,
+ operatorBaseClass,
+ retainHeader,
+ getNewNodeId(),
+ Collections.singletonList(inputProperty),
+ outputType,
+ description);
+ }
+
+ public CommonExecCorrelate(
+ FlinkJoinType joinType,
+ RexCall invocation,
+ @Nullable RexNode condition,
+ Class<?> operatorBaseClass,
+ boolean retainHeader,
+ int id,
+ List<InputProperty> inputProperty,
Review comment:
inputProperties
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala
##########
@@ -746,11 +746,12 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
val file = new File(s"./src/test/resources/$path/$fileName")
if (file.exists()) {
val expected = TableTestUtil.readFromResource(s"$path/$fileName")
+ val mapper = new ObjectMapper();
assertEquals(
- TableTestUtil.replaceExecNodeId(
- TableTestUtil.getFormattedJson(expected)),
- TableTestUtil.replaceExecNodeId(
- TableTestUtil.getFormattedJson(jsonPlanWithoutFlinkVersion)))
+ mapper.readTree(TableTestUtil.replaceExecNodeId(
Review comment:
we do not format the json if we use json node to compare.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
