xintongsong commented on a change in pull request #15279:
URL: https://github.com/apache/flink/pull/15279#discussion_r597521289
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManagerFactoryTest.java
##########
@@ -47,19 +46,19 @@
private static final MemorySize TOTAL_FLINK_SIZE =
MemorySize.ofMebiBytes(2 * 1024);
private static final MemorySize TOTAL_PROCESS_SIZE =
MemorySize.ofMebiBytes(3 * 1024);
- private static Map<String, String> systemEnv;
+ private static Properties systemProperties;
@BeforeClass
public static void setupClass() {
- systemEnv = System.getenv();
+ systemProperties = System.getProperties();
System.clearProperty("flink.tests.disable-declarative");
System.clearProperty("flink.tests.enable-fine-grained");
Review comment:
In this test class, we expect getting different effective
configurations, depending on whether fine-grained resource management is
activated or not. Thus we want this class to fully control which slot manager
is used, without being affected by the properties for the CI stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
