XComp commented on a change in pull request #15097:
URL: https://github.com/apache/flink/pull/15097#discussion_r597646366
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -135,6 +135,13 @@
"A comma separated list of URIs of custom
artifacts to be downloaded into the sandbox"
+ " of Mesos workers.");
+ public static final ConfigOption<String> MESOS_TM_USER =
+ key("mesos.resourcemenager.tasks.user")
+ .stringType()
+ .defaultValue(System.getProperty("user.name"))
Review comment:
```suggestion
.noDefaultValue()
```
That's a minor thing, but: What about removing the default value. This would
be closer to the implementation that is used right now.
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -135,6 +135,13 @@
"A comma separated list of URIs of custom
artifacts to be downloaded into the sandbox"
+ " of Mesos workers.");
+ public static final ConfigOption<String> MESOS_TM_USER =
+ key("mesos.resourcemenager.tasks.user")
+ .stringType()
+ .defaultValue(System.getProperty("user.name"))
Review comment:
The documentation needs to be updated accordingly saying that no user is
explicitly set if not specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
