[
https://issues.apache.org/jira/browse/FLINK-21696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-21696:
-----------------------------------
Labels: pull-request-available (was: )
> scala code in "Writing WatermarkGenerators" documentation missing/deprecated
> ----------------------------------------------------------------------------
>
> Key: FLINK-21696
> URL: https://issues.apache.org/jira/browse/FLINK-21696
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 1.12.2, 1.13.0
> Reporter: giackgamba
> Assignee: giackgamba
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.13.0
>
>
> Hi all,
> I belive the scala code in the "Writing a Periodic WatermarkGenerator" and
> "Writing a Punctuated WatermarkGenerator" sections ([Event Time -> Generating
> Watermark|https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/datastream/event-time/generating_watermarks/#writing-watermarkgenerators])
> is outdated/wrong.
> And it's also missing in the previous section "Writing WatermarkGenerators".
> It uses undefined arguments ({{output}}) -- the onEvent and onPeriodicEmit
> methods have the wrong signatures.
> If it's alright I can put up a PR with the scala code on how to extend
> {{WatermarkGenerator}} class and some comment.
> Also sorry if I misplaced this Issue, feel free to improve/correct
> Giack
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
