hehuiyuan commented on a change in pull request #15274:
URL: https://github.com/apache/flink/pull/15274#discussion_r598500097
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java
##########
@@ -454,22 +454,34 @@ public static void checkAcidTable(CatalogTable
catalogTable, ObjectPath tablePat
*/
public static Configuration getHadoopConfiguration(String hadoopConfDir) {
if (new File(hadoopConfDir).exists()) {
- Configuration hadoopConfiguration = new Configuration();
+ Configuration hadoopConfiguration = null;
File coreSite = new File(hadoopConfDir, "core-site.xml");
if (coreSite.exists()) {
+ if (hadoopConfiguration == null) {
Review comment:
Okay, let me change it.
I also thought about this, but what I thought at the time was to move the
code as little as possible and maintain the original structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
