Airblader commented on a change in pull request #15245:
URL: https://github.com/apache/flink/pull/15245#discussion_r598811001
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/factory/JdbcCatalogFactory.java
##########
@@ -66,40 +65,15 @@ public String factoryIdentifier() {
@Override
public Catalog createCatalog(Context context) {
- final Configuration configuration =
Configuration.fromMap(context.getOptions());
- validateConfiguration(configuration);
+ final FactoryUtil.CatalogFactoryHelper helper =
Review comment:
Sure, I'll add one good/bad case tests. The called methods themselves
are already tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
