xintongsong commented on a change in pull request #15337:
URL: https://github.com/apache/flink/pull/15337#discussion_r599461642



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/util/config/memory/ManagedMemoryUtils.java
##########
@@ -155,4 +157,20 @@ public static double getFractionRoundedDown(final long 
dividend, final long divi
                         BigDecimal.ROUND_DOWN)
                 .doubleValue();
     }
+
+    public static void validateUseCaseWeightsNoConflict(
+            Map<ManagedMemoryUseCase, Integer> 
existingOperatorScopeUseCaseWeights,
+            Map<ManagedMemoryUseCase, Integer> newOperatorScopeUseCaseWeights) 
{

Review comment:
       nit:
   Do we need to identify the two maps (in both arguments and the error 
message) by "existing" and "new"? From the perspective of this util method, it 
should make no difference which one is the existing and which one is the new.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to