curcur commented on a change in pull request #15323:
URL: https://github.com/apache/flink/pull/15323#discussion_r600150920
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/CheckpointedInputGate.java
##########
@@ -198,9 +197,6 @@ private void waitForPriorityEvents(InputGate inputGate,
MailboxExecutor mailboxE
bufferOrEvent.getChannelInfo());
} else if (bufferOrEvent.getEvent().getClass() ==
EndOfChannelStateEvent.class) {
upstreamRecoveryTracker.handleEndOfRecovery(bufferOrEvent.getChannelInfo());
- if (!upstreamRecoveryTracker.allChannelsRecovered()) {
- return pollNext();
- }
Review comment:
`pollNext()` has a unified entry-point (to be called), so why
`pollNext()` is called from where the event is handled? Is there any reason to
do so?
I can not think of one, but just to double confirm there are not certain
assumptions here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
