lindong28 commented on a change in pull request #15161:
URL: https://github.com/apache/flink/pull/15161#discussion_r600198354
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/KafkaSourceEnumerator.java
##########
@@ -407,7 +407,12 @@ public PartitionOffsetsRetrieverImpl(
.thenApply(
result -> {
Map<TopicPartition, Long> offsets = new
HashMap<>();
- result.forEach((tp, oam) ->
offsets.put(tp, oam.offset()));
+ result.forEach(
Review comment:
Yes, this test is change is verified by
`OffsetsInitializerTest#testSpecificOffsetsInitializer`, which is updated by
this PR.
The test would call `committedOffsets(partitions)` where `partitions`
include a partition that does not have committed offsets.
I verified that the test `testSpecificOffsetsInitializer` would fail if we
don't update the `committedOffsets(...)` method here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
