[
https://issues.apache.org/jira/browse/FLINK-21821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski reopened FLINK-21821:
------------------------------------
I would keep it open, as we can still clean up the closing code and fix a race
condition in disabling interrupts while closing resources. Currently this is
guarded by a volatile variable, but there might be a race condition when:
1. interrupter thread first checked the {{shouldInterruptOnCancel}} flag
2. {{shouldInterruptOnCancel}} flag switched to false as Task/StreamTask
entered cleaning up phase
3. interrupter issued an interrupt while Task/StreamTask are closing/releasing
resources, potentially causing a memory leak
> Clean up Task/StreamTask cancellation and remove unnecessary concurrency
> -------------------------------------------------------------------------
>
> Key: FLINK-21821
> URL: https://issues.apache.org/jira/browse/FLINK-21821
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Network, Runtime / Task
> Affects Versions: 1.13.0
> Reporter: Kezhu Wang
> Priority: Major
>
> I think {{AbstractInvokable.cancel}} should only do flag things but not
> closing staff. Otherwise task canceler and task thread will contend on these
> closing tasks.
> It is same for {{BatchTask.cancel}} which might be confirmed as one potential
> cause for FLINK-21728.
> cc [~dwysakowicz] [~roman_khachatryan] [~pnowojski] [~AHeise]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
