Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59710345
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -363,14 +439,31 @@ public JDBCInputFormat finish() {
if (format.dbURL == null) {
throw new IllegalArgumentException("No database
URL supplied");
}
- if (format.query == null) {
+ if (format.queryTemplate == null) {
throw new IllegalArgumentException("No query
supplied");
}
if (format.drivername == null) {
throw new IllegalArgumentException("No driver
supplied");
}
+ adjustQueryTemplateIfNecessary();
return format;
}
+
+ /** Try to add $CONDITIONS token automatically (at least for
straightforward cases) */
+ private void adjustQueryTemplateIfNecessary() {
--- End diff --
we should simply fail if a user does not supply a Condition but wants to
use splits. This is murky territory imo,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
