[
https://issues.apache.org/jira/browse/FLINK-21821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307891#comment-17307891
]
Kezhu Wang commented on FLINK-21821:
------------------------------------
Good catch [~pnowojski]. But this would also risk to whole task manager if
there are blocking operation in clean up phase. Anyway, clean shutdown without
a leaking is hard. I guess this is (part of) why {{flink cancel --savepoint}}
is not recommended.
It would be nice if {{flink stop}} can stop job without a snapshot which will
make {{flink cancel}} solely as fallback in case {{flink stop}} not working.
> Clean up Task/StreamTask cancellation and remove unnecessary concurrency
> -------------------------------------------------------------------------
>
> Key: FLINK-21821
> URL: https://issues.apache.org/jira/browse/FLINK-21821
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Network, Runtime / Task
> Affects Versions: 1.13.0
> Reporter: Kezhu Wang
> Priority: Major
>
> I think {{AbstractInvokable.cancel}} should only do flag things but not
> closing staff. Otherwise task canceler and task thread will contend on these
> closing tasks.
> It is same for {{BatchTask.cancel}} which might be confirmed as one potential
> cause for FLINK-21728.
> cc [~dwysakowicz] [~roman_khachatryan] [~pnowojski] [~AHeise]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
