dawidwys commented on a change in pull request #15241:
URL: https://github.com/apache/flink/pull/15241#discussion_r600625651
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
##########
@@ -466,9 +466,12 @@ public void onEventTime(InternalTimer<K, W> timer) throws
Exception {
mergingWindows = getMergingWindowSet();
W stateWindow =
mergingWindows.getStateWindow(triggerContext.window);
if (stateWindow == null) {
- // Timer firing for non-existent window, this can only happen
if a
- // trigger did not clean up timers. We have already cleared
the merging
- // window and therefore the Trigger state, however, so nothing
to do.
+ // Timer firing for non-existent window, this can happen:
Review comment:
There is nothing to be embarrassed about ;) I also always struggle to
use English as it is not my primary language...
Isn't it already covered by: `We have already cleared the merging window and
therefore the Trigger state` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
