[jira] [Updated] (FLINK-21968) Calcite parser doesn't support to parse "-- test"

[Shengkai Fang (Jira)]

     [ 
https://issues.apache.org/jira/browse/FLINK-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shengkai Fang updated FLINK-21968:
----------------------------------
    Description: 
Please add a test in the {{FlinkSqlParserImplTest.java}}.


{code:java}
    @Test
    public void testParseComment() {
        sql("-- test").ok("-- test");
    }
{code}


I think we can fix this by using {{ExtendedParseStrategy}} to clear the string 
that matches "--.*$";

{{ExtendedParseStrategy}} is introduced in the FLINK-21836 


  was:
Please add a test in the {{FlinkSqlParserImplTest.java}}.


{code:java}
    @Test
    public void testParseComment() {
        sql("-- test").ok("-- test");
    }
{code}


I think we can fix this by using regex to clear the string that matches "--.*$";



> Calcite parser doesn't support to parse "-- test"
> -------------------------------------------------
>
>                 Key: FLINK-21968
>                 URL: https://issues.apache.org/jira/browse/FLINK-21968
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Shengkai Fang
>            Priority: Major
>
> Please add a test in the {{FlinkSqlParserImplTest.java}}.
> {code:java}
>     @Test
>     public void testParseComment() {
>         sql("-- test").ok("-- test");
>     }
> {code}
> I think we can fix this by using {{ExtendedParseStrategy}} to clear the 
> string that matches "--.*$";
> {{ExtendedParseStrategy}} is introduced in the FLINK-21836 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)