wsry commented on a change in pull request #13924:
URL: https://github.com/apache/flink/pull/13924#discussion_r601110625
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java
##########
@@ -405,13 +413,8 @@ public ResultSubpartitionView createSubpartitionView(
checkState(isFinished(), "Trying to read unfinished blocking
partition.");
SortMergeSubpartitionReader reader =
- new SortMergeSubpartitionReader(
- subpartitionIndex,
- numDataBuffers[subpartitionIndex],
- networkBufferSize,
- this,
- availabilityListener,
- resultFile);
+ partitionReader.crateSubpartitionReader(
+ this, availabilityListener, subpartitionIndex,
resultFile);
readers.add(reader);
Review comment:
I will remove the readers set in SortMergeResultPartition and add a
hasReamingReaders method in SortMergeResultPartitionReader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
