hehuiyuan commented on a change in pull request #15274:
URL: https://github.com/apache/flink/pull/15274#discussion_r601327176



##########
File path: 
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/factories/HiveCatalogFactoryTest.java
##########
@@ -108,6 +109,26 @@ public void testCreateHiveCatalogWithHadoopConfDir() 
throws IOException {
         assertEquals(mapredVal, ((HiveCatalog) 
actualCatalog).getHiveConf().get(mapredKey));
     }
 
+    @Test
+    public void testCreateHiveCatalogWithIllegalHadoopConfDir() throws 
IOException {
+        final String catalogName = "mycatalog";
+        final String illegalHadoopConfDir = " " + 
tempFolder.newFolder().getAbsolutePath();

Review comment:
       > Why we need to add a space character to the conf dir?
   
   Set a wrong  hadoop conf path.
   Sorry, the rules of the test method are not familiar, I will learn it later, 
thank you for your guidance.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to