HuangXingBo commented on a change in pull request #15362:
URL: https://github.com/apache/flink/pull/15362#discussion_r601426371
##########
File path: docs/content/docs/dev/datastream/operators/overview.md
##########
@@ -756,4 +756,4 @@ someStream.filter(...).slotSharingGroup("name")
some_stream.filter(...).slot_sharing_group("name")
```
{{< /tab >}}
-{{< /tabs>}}
\ No newline at end of file
+{{< /tabs>}}
Review comment:
unnecessary change
##########
File path: flink-python/pyflink/datastream/data_stream.py
##########
@@ -851,28 +851,43 @@ def reduce(self, func: Union[Callable, ReduceFunction])
-> 'DataStream':
raise TypeError("The input func must be a ReduceFunction or a
callable function.")
output_type =
_from_java_type(self._original_data_type_info.get_java_type_info())
- class KeyedReduceFunctionWrapper(KeyedProcessFunction):
+ class KeyedReduceProcessFunction(KeyedProcessFunction):
Review comment:
Maybe we can rename other wrapper functions together
##########
File path: flink-python/pyflink/datastream/functions.py
##########
@@ -758,9 +760,7 @@ class KeyedProcessFunction(Function, ABC):
Note that access to keyed state and timers (which are also scoped to a
key) is only available if
the KeyedProcessFunction is applied on a KeyedStream.
- """
- """
A function that process elements of a stream.
Review comment:
I think this useless comment also needs to be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
