kezhuw commented on a change in pull request #15344:
URL: https://github.com/apache/flink/pull/15344#discussion_r601523982
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java
##########
@@ -198,16 +205,17 @@ public static void assertThrows(
@SuppressWarnings("BusyWait")
public static void waitUtil(Supplier<Boolean> condition, Duration timeout,
String errorMsg)
throws TimeoutException, InterruptedException {
- long timeoutMs = timeout.toMillis();
- if (timeoutMs <= 0) {
+ long timeoutNanos = timeout.toNanos();
+ if (timeoutNanos <= 0) {
throw new IllegalArgumentException("The timeout must be
positive.");
}
- long startingTime = System.currentTimeMillis();
- while (!condition.get() && System.currentTimeMillis() - startingTime <
timeoutMs) {
+ long startingTime = System.nanoTime();
Review comment:
I think we have options here:
1. Keep it as is.
2. Migrate `CommonTestUtils.waitUtil` to
`CommonTestUtils.waitUntilCondition`.
3. If 2, we could also provide `Duration` overloads for all exiting
`waitUntilCondition` overloads.
What do you think ? The last two options will make this a bit fragment, but
all related to `waitXyz`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
